Skip to content

build(dev-deps): switch to npm-run-all2 - #126

Closed
dsanders11 wants to merge 1 commit into
mainfrom
build/switch-to-npm-run-all2
Closed

build(dev-deps): switch to npm-run-all2#126
dsanders11 wants to merge 1 commit into
mainfrom
build/switch-to-npm-run-all2

Conversation

@dsanders11

Copy link
Copy Markdown
Member

npm-run-all is unmaintained and hasn't had a publish in 6 years, npm-run-all2 is a maintained fork.

@dsanders11
dsanders11 force-pushed the build/switch-to-npm-run-all2 branch from b33befa to 8d936cf Compare July 8, 2025 23:58
@dsanders11
dsanders11 marked this pull request as ready for review July 9, 2025 00:04
@dsanders11
dsanders11 requested a review from a team as a code owner July 9, 2025 00:04
@erikian

erikian commented Jul 9, 2025

Copy link
Copy Markdown
Member

Can't we just remove that dependency? We only seem to use it for parallelizing the lint and lint:fix scripts (it's also used in the make script but I'm not sure why since it only calls one other script), and modifying them to run in series increases the total running time by like 0.3s for me, so not sure it's worth the trouble.

@dsanders11

Copy link
Copy Markdown
Member Author

Yea, that's a good point, I should have looked closer at our actual usage here. I agree that it's not worth the dependency given how limited the usage is here. I'll close this PR and open a different one to remove it.

@dsanders11 dsanders11 closed this Jul 9, 2025
@dsanders11
dsanders11 deleted the build/switch-to-npm-run-all2 branch December 3, 2025 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants