Skip to content

Granite.CssClass.DESTRUCTIVE and Granite.CssClass.SUGGESTED class names do not match pre-7.7.0 & Adw counterparts #986

Description

@wpkelso

We probably should keep with adw's definition for the class for compatibility purposes, and we already were following it pre-7.7.0.

destructive-action

/* granite/lib/Constants.vala */
/**
 * Style class for {@link Gtk.Button} with a destructive action
 */
[Version (deprecated = true, deprecated_since = "7.7.0", replacement = "Granite.CssClass.DESTRUCTIVE")]
public const string STYLE_CLASS_DESTRUCTIVE_ACTION = "destructive-action";

/**
 * Style class for {@link Gtk.Button} with a destructive action
 */
[Version (since = "7.7.0")]
public const string DESTRUCTIVE = "destructive";

https://gnome.pages.gitlab.gnome.org/libadwaita/doc/main/style-classes.html#destructive-action

suggested-action

/* granite/lib/Constants.vala */
/**
 * Style class for when an action (usually a button) is the primary suggested action in a specific context.
 */
[Version (deprecated = true, deprecated_since = "7.7.0", replacement = "Granite.CssClass.SUGGESTED")]
public const string STYLE_CLASS_SUGGESTED_ACTION = "suggested-action";

/**
 * Style class for when a {@link Gtk.Button} is the primary suggested action in a specific context.
 */
[Version (since = "7.7.0")]
public const string SUGGESTED = "suggested";

https://gnome.pages.gitlab.gnome.org/libadwaita/doc/main/style-classes.html#suggested-action

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions