Skip to content

Styles/lighting: toplevel shadows - #1034

Merged
danirabbit merged 16 commits into
mainfrom
danirabbit/styles-toplevelshadow
Sep 27, 2026
Merged

danirabbit merged 16 commits into
mainfrom
danirabbit/styles-toplevelshadow

Conversation

@danirabbit

Copy link
Copy Markdown
Member

First steps towards eventually removing the shadow function. Use class extends for toplevels

@danirabbit
danirabbit requested a review from a team September 9, 2026 17:47
@danirabbit
danirabbit marked this pull request as draft September 9, 2026 17:51
@danirabbit
danirabbit marked this pull request as ready for review September 9, 2026 18:06
@danirabbit danirabbit added this to OS 9 Sep 9, 2026
@danirabbit danirabbit moved this to Needs Review in OS 9 Sep 9, 2026
Comment thread lib/Styles/Common/_lighting.scss Outdated

@wpkelso wpkelso left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danirabbit
danirabbit enabled auto-merge (squash) September 27, 2026 19:14
@danirabbit
danirabbit merged commit c0d4252 into main Sep 27, 2026
3 of 5 checks passed
@danirabbit
danirabbit deleted the danirabbit/styles-toplevelshadow branch September 27, 2026 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants