Fix multi-line use site detection without regex#339
Merged
Conversation
lukaszsamson
changed the title
lukaszsamson
marked this pull request as ready for review
July 4, 2026 06:56
katafrakt
added a commit
to expert-lsp/expert
that referenced
this pull request
Jul 6, 2026
This is especially useful with Ecto and jumping to functions like `MyApp.Repo.all`. Currently it takes the user to `use Ecto.Repo` inside `my_app/repo.ex`, but after this change the user actually lands in Ecto source. The real changes are made in ElixirSense, this just updates the dependency and unskips the test verifying this behaviour. * elixir-lsp/elixir_sense#333 * elixir-lsp/elixir_sense#339
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is an alternative to #335 that keeps the same regression coverage but avoids the regex-based
usedetector.It changes
use_site?/3to:Code.string_to_quoted/2Code.Fragment.container_cursor_to_quoted/2for incomplete lines such asuse Foo,use/Kernel.usecall on the recorded definition lineValidation
mix format --check-formattedmix test test/elixir_sense/providers/definition/locator_using_macro_test.exsmix test