Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Document urlPattern collection property, and add route to catch new pages where missing in the templates #1099
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Uh oh!
There was an error while loading. Please reload this page.
Document urlPattern collection property, and add route to catch new pages where missing in the templates #1099
Changes from all commits
b664ba7168330a4ab8f78b27bb6e9df1fc1797ca8aFile filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[needs fixing] Same regression as the non-Cloudflare marketing template: removing the default
Astro.url.hrefmeans existing pages and the new[slug].astroroute lose canonical links andog:urlmeta tags because no caller passes thecanonicalprop.Restore the fallback:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[needs fixing] Removing the default
canonical: Astro.url.hrefcauses a regression: all existing pages (contact.astro,pricing.astro,index.astro) and the new[slug].astrodynamic pages will no longer emit<link rel="canonical">orog:urlmeta tags, because none of them pass acanonicalprop toBase. Previously every page had a canonical URL derived fromAstro.url.href.Restore the fallback so existing pages keep working while still allowing overrides via the new prop:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[needs fixing] Same regression as the non-Cloudflare portfolio template: removing the default
Astro.url.hrefdrops canonical links andog:urltags for all pages that don't explicitly pass acanonicalprop.Restore the fallback:
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.