feat(admin): add table support to PortableText editor by tohaitrieu · Pull Request #222 · emdash-cms/emdash

tohaitrieu · 2026-04-04T06:36:15Z

What does this PR do?

Adds table support to the TipTap/PortableText editor in the admin UI. Users can now insert, edit, and manage tables in content with proper toolbar controls.

Changes:

Add TipTap table extensions (Table, TableRow, TableCell, TableHeader)
Add table controls to editor toolbar
Style tables for consistent appearance

Discussion: #217

Type of change

Checklist

I have read CONTRIBUTING.md
pnpm typecheck passes
pnpm --silent lint:json | jq '.diagnostics | length' returns 0
pnpm test passes (or targeted tests for my change)
pnpm format has been run
I have added/updated tests for my changes (if applicable)
I have added a changeset (if this PR changes a published package)
New features link to an approved Discussion: Feature: Table support in the editor #217

changeset-bot · 2026-04-04T06:36:22Z

🦋 Changeset detected

Latest commit: 0be5376

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages

Name	Type
@emdash-cms/admin	Major
emdash	Major
@emdash-cms/auth-atproto	Major
@emdash-cms/cloudflare	Major
@emdash-cms/fixture-perf-site	Patch
@emdash-cms/perf-demo-site	Patch
@emdash-cms/cache-demo-site	Patch
@emdash-cms/auth	Major
@emdash-cms/blocks	Major
@emdash-cms/gutenberg-to-portable-text	Major
@emdash-cms/x402	Major
create-emdash	Major
@emdash-cms/plugin-embeds	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions · 2026-04-04T06:38:15Z

All contributors have signed the CLA ✍️ ✅
_{Posted by the CLA Assistant Lite bot.}

tohaitrieu · 2026-04-04T06:45:58Z

I have read the CLA Document and I hereby sign the CLA

pkg-pr-new · 2026-04-04T08:05:56Z

Open in StackBlitz

@emdash-cms/admin

npm i https://pkg.pr.new/@emdash-cms/admin@222

@emdash-cms/auth

npm i https://pkg.pr.new/@emdash-cms/auth@222

@emdash-cms/blocks

npm i https://pkg.pr.new/@emdash-cms/blocks@222

@emdash-cms/cloudflare

npm i https://pkg.pr.new/@emdash-cms/cloudflare@222

emdash

npm i https://pkg.pr.new/emdash@222

create-emdash

npm i https://pkg.pr.new/create-emdash@222

@emdash-cms/gutenberg-to-portable-text

npm i https://pkg.pr.new/@emdash-cms/gutenberg-to-portable-text@222

@emdash-cms/x402

npm i https://pkg.pr.new/@emdash-cms/x402@222

@emdash-cms/plugin-ai-moderation

npm i https://pkg.pr.new/@emdash-cms/plugin-ai-moderation@222

@emdash-cms/plugin-atproto

npm i https://pkg.pr.new/@emdash-cms/plugin-atproto@222

@emdash-cms/plugin-audit-log

npm i https://pkg.pr.new/@emdash-cms/plugin-audit-log@222

@emdash-cms/plugin-color

npm i https://pkg.pr.new/@emdash-cms/plugin-color@222

@emdash-cms/plugin-embeds

npm i https://pkg.pr.new/@emdash-cms/plugin-embeds@222

@emdash-cms/plugin-forms

npm i https://pkg.pr.new/@emdash-cms/plugin-forms@222

@emdash-cms/plugin-webhook-notifier

npm i https://pkg.pr.new/@emdash-cms/plugin-webhook-notifier@222

commit: 0be5376

ascorbic · 2026-04-04T16:19:15Z

Thanks! Could you add a changeset, so this is included in the changelog and triggers a release. There's more info in CONTRIBUTING.md

ascorbic · 2026-04-04T16:44:22Z

There seems to be quite a bit of extra stuff in here, beyond the main feature

github-actions · 2026-04-06T07:55:45Z

Overlapping PRs

This PR modifies files that are also changed by other open PRs:

feat(core): add group and sortOrder to collections for admin UI organization #292 (4 shared files)

This may cause merge conflicts or duplicated work. A maintainer will coordinate.

ascorbic

Thanks. This is a great addition. It just needs a few changes. Can you also add unit tests for both conversion directions and ensure oyu have completed the checklist in the description.

ascorbic · 2026-04-11T10:14:26Z

+
+.ProseMirror td,
+.ProseMirror th {
+	border: 1px solid #d1d5db;


Can we avoid using hard-coded colours. The rest of the admin UI uses Tailwind and Kumo design tokens, and these won't follow that. That applies to the other places in here too.

ascorbic · 2026-04-11T10:15:29Z

+    "@tiptap/extension-table": "^3.22.1",
+    "@tiptap/extension-table-cell": "^3.22.1",
+    "@tiptap/extension-table-header": "^3.22.1",
+    "@tiptap/extension-table-row": "^3.22.1",


Can we use catalog dependencies here, and ensure they match the other tiptap extension versions

ascorbic · 2026-04-11T10:23:24Z

+							: "tableCell";
+
+					// Map PortableText marks to ProseMirror marks
+					const markNameMap: Record<string, string> = {


There's already a convertPTMarks function in this file that handles the PT/PM mark mapping. Please use that instead of the inline markNameMap here – it handles link markDefs too, which this version silently drops.

github-actions · 2026-04-25T13:19:44Z

This PR has been inactive for 14 days. It will be closed automatically in 7 days if there is no further activity.

If you're still working on this, please push an update or leave a comment.

ascorbic · 2026-04-27T12:08:47Z

@tohaitrieu it would be great to get this in! It shouldn't take much to get it ready

- Add TipTap table extensions (Table, TableRow, TableCell, TableHeader) - Add table controls to editor toolbar with slash command (/table) - Add TableBubbleMenu for editing tables (add/remove rows/columns) - Update PT↔PM converters with proper markDefs handling for links - Use Kumo design tokens for table styling (no hard-coded colors) - Add unit tests for table conversion in both directions

oiwa-coder · 2026-04-28T04:33:25Z

@tohaitrieu you still working on this? if not ill make one.

github-actions Bot added a commit that referenced this pull request Apr 4, 2026

@tohaitrieu has signed the CLA in #222

04b84d0

tohaitrieu force-pushed the feat/table-support branch from 78907f8 to 7ecfe74 Compare April 4, 2026 10:45

tohaitrieu force-pushed the feat/table-support branch from 91a8cbf to 09eb300 Compare April 4, 2026 16:43

tohaitrieu force-pushed the feat/table-support branch from 09eb300 to 96ba2e1 Compare April 5, 2026 02:33

github-actions Bot added needs-approval area/admin size/L cla: signed overlap and removed needs-approval labels Apr 5, 2026

github-actions Bot mentioned this pull request Apr 6, 2026

feat(core): add group and sortOrder to collections for admin UI organization #292

Open

15 tasks

ascorbic reviewed Apr 11, 2026

View reviewed changes

ascorbic added the Awaiting author response label Apr 11, 2026

github-actions Bot added stale and removed stale labels Apr 25, 2026

github-actions Bot added size/XL and removed size/L labels Apr 27, 2026

tohaitrieu force-pushed the feat/table-support branch from 423aaeb to f0fd068 Compare April 27, 2026 13:14

github-actions Bot added area/ci area/core area/docs labels Apr 27, 2026

github-actions Bot added the needs-rebase label Apr 27, 2026

tohaitrieu force-pushed the feat/table-support branch from f0fd068 to 20166f8 Compare April 27, 2026 13:19

github-actions Bot removed the needs-rebase label Apr 27, 2026

tohaitrieu force-pushed the feat/table-support branch 2 times, most recently from ad03e33 to d68dc52 Compare April 27, 2026 13:26

tohaitrieu force-pushed the feat/table-support branch from c1b7ad7 to 0be5376 Compare April 27, 2026 15:02

github-actions Bot added the needs-rebase label May 2, 2026

jcheese1 mentioned this pull request May 6, 2026

feat(admin): add table support to PortableText editor #921

Merged

18 tasks

ascorbic closed this in #921 May 6, 2026

Conversation

tohaitrieu commented Apr 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Type of change

Checklist

Uh oh!

changeset-bot Bot commented Apr 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

github-actions Bot commented Apr 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tohaitrieu commented Apr 4, 2026

Uh oh!

pkg-pr-new Bot commented Apr 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ascorbic commented Apr 4, 2026

Uh oh!

ascorbic commented Apr 4, 2026

Uh oh!

github-actions Bot commented Apr 6, 2026

Overlapping PRs

Uh oh!

ascorbic left a comment

Choose a reason for hiding this comment

Uh oh!

ascorbic Apr 11, 2026

Choose a reason for hiding this comment

Uh oh!

ascorbic Apr 11, 2026

Choose a reason for hiding this comment

Uh oh!

ascorbic Apr 11, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Apr 25, 2026

Uh oh!

ascorbic commented Apr 27, 2026

Uh oh!

oiwa-coder commented Apr 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

tohaitrieu commented Apr 4, 2026 •

edited

Loading

changeset-bot Bot commented Apr 4, 2026 •

edited

Loading

github-actions Bot commented Apr 4, 2026 •

edited

Loading

pkg-pr-new Bot commented Apr 4, 2026 •

edited

Loading