[DIAG — do not merge] withdll stdout probe - #122
Closed
emeryberger wants to merge 3 commits into
Closed
Conversation
Owner
Author
|
Mystery solved. With the current (fixed) withdll, all four probes capture the grandchild's stdout — including PROBE D, which replicates the watchdog's exact And this run's actual watchdog So the withdll fix (alloc8#14) was correct and sufficient by itself. My earlier "the fix alone didn't work" was a stale-binary observation: that CI run had fetched pre-merge alloc8 (a ~2s merge/rerun race, flagged at the time) and ran the old Detours-sample withdll. BENCH_OUT (#119) remains as belt-and-suspenders — it's more robust and is what the QoS gate parses. Closing; diagnostic reverted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Diagnostic to figure out why the injected process's stdout isn't captured through withdll. Probe A: trivial cmd-echo grandchild (isolates handle inheritance). Probe B: larson (real case). Probe C: larson without injection (control). Will be closed unmerged.