[router] Warn on unknown retry_on policy tokens#45349
Open
nezdolik wants to merge 1 commit into
Open
Conversation
Signed-off-by: Kateryna Nezdolii <kateryna.nezdolii@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an xDS retry_on config contains unrecognized tokens (e.g., typos like "5x" instead of "5xx"), Envoy previously accepted the config silently and discarded the unknown tokens without any indication.
This PR adds a rate-limited warning log at config ingestion listing any unrecognized tokens.
Commit Message: [router] Warn on unknown retry_on policy tokens
Additional Description:
Risk Level: Low
Testing: Unit test
Docs Changes:
Release Notes:
Platform Specific Features:
Fixes #39470