oauth2: Add support for configurable post_logout_redirect_uri#45367
Open
funkluk wants to merge 1 commit into
Conversation
|
Hi @funkluk, welcome and thank you for your contribution. We will try to review your Pull Request as quickly as possible. In the meantime, please take a look at the contribution guidelines if you have not done so already. |
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #41644
Please bear with me, this is my first PR to the envoy-proxy project and any guidance is welcome.
Commit Message:
OIDC RP-initiated logout currently carries a hardcoded
post_logout_redirect_uri. According to the OIDC specification,post_logout_redirect_uriis optional; implementers should be able to decide whether to include it and, if included, what value to use.Two new, optional configuration settings allow specifying the desired URI or omitting the
post_logout_redirect_uriparameter completely. If not defined, the current behaviour is kept, by adding the value<scheme>://<host>/for thepost_logout_redirect_uriparameter.Risk Level: Low
Testing:
Added additional integration tests.
If more tests are required, please guide me what kind of tests and with an example.
Docs Changes:
No additional docs except the API description was done.
Release Notes:
see
changelogs/current/new_features/oauth2__added_support_to_configure_post_logout_redirect_uri_parameter.rstNot sure if this is the right way to add release notes or if I just have to add it to the
current.yaml.API changes:
Two new fields have be added to the oauth2 config:
post_logout_redirect_uri(optional): allows specifying the required uri the OIDC OP should redirect back todisable_post_logout_redirect_uri(optional): if set to true, thepost_logout_redirect_uriquery parameter is omitted from theend_session_endpointrequest.