-
Notifications
You must be signed in to change notification settings - Fork 5.4k
mcp_transcoder: add sse server response support. #45374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
guoyilin42
wants to merge
3
commits into
envoyproxy:main
Choose a base branch
from
guoyilin42:sse
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
53 changes: 53 additions & 0 deletions
53
source/extensions/filters/http/mcp_json_rest_bridge/sse_response_extractor.cc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| #include "source/extensions/filters/http/mcp_json_rest_bridge/sse_response_extractor.h" | ||
|
|
||
| #include <string> | ||
| #include <utility> | ||
| #include <vector> | ||
|
|
||
| #include "source/common/http/sse/sse_parser.h" | ||
|
|
||
| #include "absl/strings/string_view.h" | ||
|
|
||
| namespace Envoy { | ||
| namespace Extensions { | ||
| namespace HttpFilters { | ||
| namespace McpJsonRestBridge { | ||
|
|
||
| std::vector<std::string> SseResponseExtractor::processChunk(absl::string_view chunk, | ||
| bool end_stream) { | ||
| std::vector<std::string> event_payloads; | ||
| buffer_.append(chunk.data(), chunk.size()); | ||
|
guoyilin42 marked this conversation as resolved.
|
||
|
|
||
| absl::string_view buffer_view = buffer_; | ||
| const uint64_t length = buffer_.size(); | ||
|
|
||
| while (!buffer_view.empty()) { | ||
| // Safely handles chunk boundaries and all line-ending formats | ||
| auto result = Http::Sse::SseParser::findEventEnd(buffer_view, end_stream); | ||
|
guoyilin42 marked this conversation as resolved.
Outdated
|
||
|
|
||
| // npos means the event hasn't reached a double blank line yet | ||
| if (result.event_start == absl::string_view::npos) { | ||
| break; | ||
| } | ||
|
|
||
| absl::string_view event_str = | ||
| buffer_view.substr(result.event_start, result.event_end - result.event_start); | ||
|
|
||
| Http::Sse::SseParser::ParsedEvent event = Http::Sse::SseParser::parseEvent(event_str); | ||
|
|
||
| if (event.data.has_value()) { | ||
| event_payloads.push_back(*std::move(event.data)); | ||
| } | ||
|
|
||
| buffer_view = buffer_view.substr(result.next_start); | ||
| } | ||
|
|
||
| buffer_.erase(0, length - buffer_view.size()); | ||
|
|
||
| return event_payloads; | ||
| } | ||
|
|
||
| } // namespace McpJsonRestBridge | ||
| } // namespace HttpFilters | ||
| } // namespace Extensions | ||
| } // namespace Envoy | ||
28 changes: 28 additions & 0 deletions
28
source/extensions/filters/http/mcp_json_rest_bridge/sse_response_extractor.h
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| #pragma once | ||
|
|
||
| #include <string> | ||
| #include <vector> | ||
|
|
||
| #include "absl/strings/string_view.h" | ||
|
|
||
| namespace Envoy { | ||
| namespace Extensions { | ||
| namespace HttpFilters { | ||
| namespace McpJsonRestBridge { | ||
|
|
||
| class SseResponseExtractor { | ||
| public: | ||
| SseResponseExtractor() = default; | ||
|
|
||
| // Processes an incoming chunk of an SSE stream and returns any completed event payloads. | ||
| // Set end_stream to true if this is the final chunk of the response. | ||
| std::vector<std::string> processChunk(absl::string_view chunk, bool end_stream = false); | ||
|
guoyilin42 marked this conversation as resolved.
Outdated
|
||
|
|
||
| private: | ||
| std::string buffer_; | ||
| }; | ||
|
|
||
| } // namespace McpJsonRestBridge | ||
| } // namespace HttpFilters | ||
| } // namespace Extensions | ||
| } // namespace Envoy | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we going to support SSE case when
text_content_streaming_enabled: Falsein the follow-up change?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought our plan is to support SSE in non-buffering case. I could add the buffering support for SSE in this PR if that's needed.