Generalize export obs tool#13746
Open
SAKavli wants to merge 10 commits into
Open
Conversation
We want to create a folder structure, but where the folder should go is still unclear, might move later.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #13746 +/- ##
=======================================
Coverage ? 90.38%
=======================================
Files ? 472
Lines ? 33453
Branches ? 0
=======================================
Hits ? 30235
Misses ? 3218
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more.
|
We will support multiple formats in the future, so we should generalize the args to support different output formats.
We will create multiple exporters, which all which have a shared behaviour
a9f3626 to
c174f62
Compare
624626d to
61a941a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Resolves #13726
Approach
Short description of the approach
(Screenshot of new behavior in GUI if applicable)
git rebase -i main --exec 'just rapid-tests')When applicable