Skip to content

Fix flaky UtxoStateNodesSyncSpec: compare best-chain headers, not every known header #2452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ergologica wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix flaky UtxoStateNodesSyncSpec: compare best-chain headers, not every known header #2452

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions src/it/scala/org/ergoplatform/it/UtxoStateNodesSyncSpec.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,16 @@ class UtxoStateNodesSyncSpec extends AnyFlatSpec with IntegrationSuite {
log.info(
s"Headers at height ${initHeight + blocksQty - forkDepth}: ${headers.mkString(",")}"
)
val headerIdsAtSameHeight = headers.flatten
val sample = headerIdsAtSameHeight.head
headerIdsAtSameHeight should contain only sample
// `/blocks/at/{height}` returns *every* header id known at the given height, with the
// best-chain one first (see `HeadersProcessor.headerIdsAtHeight`). Nodes are in sync
// when their best-chain header at that height matches; a node may legitimately also
// know orphaned headers of a fork that was already resolved, so flattening all the
// returned ids makes the assertion fail on a perfectly synchronised network.
// Same convention as ForkResolutionSpec and DeepRollBackSpec, which compare `.head`.
headers.foreach(_ should not be empty)
val bestChainHeaderIds = headers.map(_.head)
val sample = bestChainHeaderIds.head
bestChainHeaderIds should contain only sample
}
Await.result(result, 15.minutes)
}
Expand Down
Loading