Document interlinksProof in the PopowHeader OpenAPI schema - #2459
Merged
kushti merged 1 commit intoAug 11, 2026
Merged
Conversation
PoPowHeader's encoder emits interlinksProof and its decoder requires it, but the PopowHeader schema listed only header and interlinks, so the documented shape did not match the one the node serves. Add the field, and a BatchMerkleProof schema matching what batchMerkleProofEncoder produces. Noticed while reading ergoplatform#1384.
kushti
approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PoPowHeader's encoder emitsinterlinksProof(PoPowHeader.scala:126) and its decoder requires it (:134), but thePopowHeaderschema inopenapi.yaml:1583listed onlyheaderandinterlinks. The documented shape did not match the one the node actually serves.Adds the field, plus a
BatchMerkleProofschema matching whatbatchMerkleProofEncoder(PoPowHeader.scala:81) produces:indicesas{index, digest}pairs andproofsas{digest, side}pairs.Documentation only, no code paths touched. Noticed while reading #1384 — not a bounty claim, that work was @ApexTheory's in #1526.