ergo-nipopow: validate proof structure and extension-root binding - #917
Open
a-shannon wants to merge 11 commits into
Open
ergo-nipopow: validate proof structure and extension-root binding#917a-shannon wants to merge 11 commits into
a-shannon wants to merge 11 commits into
Conversation
a-shannon
marked this pull request as draft
August 6, 2026 12:27
This was referenced Aug 6, 2026
a-shannon
marked this pull request as ready for review
August 6, 2026 22:39
Author
|
Review acknowledgement: many thanks to Muadib for the thorough initial security review, the reproducible test cases, and the independent re-audit of this exact head ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Invariant
A disclosed interlink is accepted only when its Merkle proof reconstructs the full extension root committed by the header, and proof comparison is entered only with valid structural parameters.
Public API behavior note
The corrective update restores the historical exhaustive
NipopowProofErrorvariant set. Detailed proof-local validation outcomes are exposed separately through the#[non_exhaustive] NipopowValidationErrorreturned byNipopowProof::validate.valid_proof.is_better_than(&invalid_proof)returnsOk(true), preserving the historical base comparison behavior.(m, k)values returnsOk(false).NipopowVerifier::processreports a valid challenger parameter mismatch as the legacyAutolykosPowSchemeError::OutOfBoundsbefore mutation; the incumbent remains unchanged.Ok(())and cannot replace the incumbent.Coordination
Validation
Independent maintainer review and upstream CI are pending.
Downstream consumer