Kuba/ssh/fixup zero fault tests#11204
Open
u3s wants to merge 3 commits into
Open
Conversation
On systems where the crypto backend lacks ML-KEM support (e.g. LibreSSL 4.3.0 on OpenBSD 7.9), the Erlang SSH server cannot offer mlkem768x25519-sha256. Recent OpenSSH clients emit a warning when a non-PQ kex is negotiated, causing eserver_oclient_kex_strict and erlang_server_openssh_client_renegotiate to fail. Only fail on the PQC warning when mlkem768 is actually available in the crypto backend. Otherwise log and continue, since the warning is expected and the test validates kex strict/renegotiation, not PQC.
Contributor
CT Test Results 2 files 29 suites 26m 2s ⏱️ Results for commit 5c0e87b. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts
// Erlang/OTP Github Action Bot |
On OpenBSD 7.9 (LibreSSL 4.3.0), ssh-dss is not available in the crypto backend. The no_common_alg tests used ssh-dss as the client algorithm to create a deliberate mismatch, but ssh_options:handle_options rejects it before any network communication on platforms without DSA. Use ssh-ed25519 (server) and ecdsa-sha2-nistp256 (client) instead. Both are universally available and create the same "no overlap" scenario the tests validate.
u3s
force-pushed
the
kuba/ssh/fixup_zero_fault_tests
branch
from
fe27ac2 to
ed69c98
Compare
Replace ct:sleep(100) + single gen_tcp:recv with a loop that accumulates data until the kex-strict indicator is found or 4096 bytes received. The previous approach was timing-dependent and could fail when the KEXINIT data arrived in multiple TCP segments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.