Skip to content

refactor: rename type definitions in no-duplicate-keyframe-selectors - #602

Merged
nzakas merged 1 commit into
mainfrom
refactor/no-duplicate-keyframe-selectors-type-names
Oct 29, 2026
Merged

nzakas merged 1 commit into
mainfrom
refactor/no-duplicate-keyframe-selectors-type-names

Conversation

@Pixel998

@Pixel998 Pixel998 commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Prerequisites checklist

AI acknowledgment

  • I did not use AI to generate this PR.
  • (If the above is not checked) I have reviewed the AI-generated content before submitting.

What is the purpose of this pull request?

This PR renames the type definitions in no-duplicate-keyframe-selectors to match the rule name, as the other rules do.

What changes did you make? (Give an overview)

Added the missing No prefix and plural s to both type names.

Related Issues

Is there anything you'd like reviewers to focus on?

Summary by CodeRabbit

  • Documentation
    • Updated internal type annotations for the duplicate keyframe selector rule. The rule’s behavior and its effect on users remain unchanged.

@coderabbitai

coderabbitai Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Central YAML; Path: .coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 6119d09f-1131-424a-ab27-279e86711a53
Commits

Reviewing files that changed from the base of the PR and between 48637ef and 48b937f.

Files selected for processing: 1
  • src/rules/no-duplicate-keyframe-selectors.js

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.

Walkthrough

The rule’s JSDoc typedefs now use the NoDuplicateKeyframeSelectors prefix. The default export’s @satisfies annotation references the renamed rule-definition typedef. Runtime behavior is unchanged.

Changes: Keyframe selector typedefs

Layer / File(s) Summary
Rename rule typedefs
src/rules/no-duplicate-keyframe-selectors.js
The message-ID and rule-definition typedefs use the NoDuplicateKeyframeSelectors prefix. The default export’s @satisfies annotation references the renamed rule-definition typedef.

Priority: Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Refactor

Suggested reviewers: snitin315

Merge Risk: Minimal · up to 48b93

The type names are updated consistently, with no runtime change or actionable merge-blocking risk identified. Mergeable after normal checks.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly describes the main change: renaming type definitions in no-duplicate-keyframe-selectors.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 1 files.

Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Pixel998 Pixel998 moved this from Needs Triage to Implementing in Triage Oct 29, 2026

@nzakas nzakas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@nzakas
nzakas merged commit 7d08062 into main Oct 29, 2026
39 checks passed
@nzakas
nzakas deleted the refactor/no-duplicate-keyframe-selectors-type-names branch October 29, 2026 17:53
@github-project-automation github-project-automation Bot moved this from Implementing to Complete in Triage Oct 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Complete

Development

Successfully merging this pull request may close these issues.

2 participants