Skip to content

feat: check transition/will-change in prefer-logical-properties - #611

Open
Pixel998 wants to merge 1 commit into
mainfrom
feat/prefer-logical-properties-transition-will-change
Open

Pixel998 wants to merge 1 commit into
mainfrom
feat/prefer-logical-properties-transition-will-change

Conversation

@Pixel998

Copy link
Copy Markdown
Contributor

Prerequisites checklist

AI acknowledgment

Check all that apply.

  • I did not use AI to generate this PR.
  • I used AI to write or edit the description of this PR (including translation).
  • I used AI to understand the codebase.
  • I used AI to write or edit the files in this PR and I reviewed the files.

What did you do?

/* eslint css/prefer-logical-properties: "error" */

a {
	margin-inline-start: 10px;
	transition: margin-left 0.3s;
}

What did you expect to happen?

margin-left in transition to be reported.

What actually happened?

No error.

What is the purpose of this pull request?

This PR makes prefer-logical-properties check the property names in transition, transition-property and will-change, so physical names there are reported with their logical counterparts as suggestions.

What changes did you make? (Give an overview)

Checked each property name in transition, transition-property and will-change values against the existing property mappings.

Related Issues

Is there anything you'd like reviewers to focus on?

@coderabbitai

coderabbitai Bot commented Oct 31, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 13 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 2 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Central YAML; Path: .coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: f2b392c6-a6cb-4c57-beb3-afbbcab8bb2f
Commits

Reviewing files that changed from the base of the PR and between 79e7d51 and e8365c1.

Files selected for processing: 3
  • docs/rules/prefer-logical-properties.md
  • src/rules/prefer-logical-properties.js
  • tests/rules/prefer-logical-properties.test.js
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@Pixel998 Pixel998 moved this from Needs Triage to Implementing in Triage Oct 31, 2026

@DMartens DMartens left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, thanks. Leaving open for second review.

@DMartens DMartens added the accepted There is consensus among the team that this change meets the criteria for inclusion label Nov 1, 2026
@DMartens DMartens moved this from Implementing to Second Review Needed in Triage Nov 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

accepted There is consensus among the team that this change meets the criteria for inclusion feature

Projects

Status: Second Review Needed

Development

Successfully merging this pull request may close these issues.

2 participants