Skip to content

fix: handle symbol in validateLanguageOptions #722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fasttime merged 1 commit into from
Aug 31, 2026
Merged

fix: handle symbol in validateLanguageOptions #722

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/language/markdown-language.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@ export class MarkdownLanguage {
!validFrontmatterOptions.has(frontmatterOption)
) {
throw new Error(
`Invalid language option value \`${frontmatterOption}\` for frontmatter. Expected one of \`false\`, \`"yaml"\`, \`"toml"\`, or \`"json"\`.`,
`Invalid language option value \`${String(frontmatterOption)}\` for frontmatter. Expected one of \`false\`, \`"yaml"\`, \`"toml"\`, or \`"json"\`.`,
);
}

Expand All @@ -194,7 +194,7 @@ export class MarkdownLanguage {

if (mathOption !== undefined && typeof mathOption !== "boolean") {
throw new Error(
`Invalid language option value \`${mathOption}\` for math. Expected a boolean.`,
`Invalid language option value \`${String(mathOption)}\` for math. Expected a boolean.`,
);
}
}
Expand Down
22 changes: 22 additions & 0 deletions tests/language/markdown-language.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,17 @@ describe("MarkdownLanguage", () => {
'Invalid language option value `123` for frontmatter. Expected one of `false`, `"yaml"`, `"toml"`, or `"json"`.',
},
);
assert.throws(
() => {
language.validateLanguageOptions({
frontmatter: Symbol("frontmatter"),
});
},
{
message:
'Invalid language option value `Symbol(frontmatter)` for frontmatter. Expected one of `false`, `"yaml"`, `"toml"`, or `"json"`.',
},
);
});

it("should not throw an error when `frontmatter` has a correct value in commonmark mode", () => {
Expand Down Expand Up @@ -116,6 +127,17 @@ describe("MarkdownLanguage", () => {
"Invalid language option value `123` for math. Expected a boolean.",
},
);
assert.throws(
() => {
language.validateLanguageOptions({
math: Symbol("math"),
});
},
{
message:
"Invalid language option value `Symbol(math)` for math. Expected a boolean.",
},
);
});

it("should not throw an error when `math` has a correct value in commonmark mode", () => {
Expand Down