You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This pull request introduces a new test suite for the conftest.py fixtures and expands and refactors the existing test suite for runtime_table_generator.py. The changes improve test coverage, add new test cases (especially for coverage badge logic), and enhance test robustness and maintainability. The most important changes are:
New Test Suite for conftest.py Fixtures:
Adds .github/scripts/ci_testing/test_conftest_fixtures.py, a comprehensive test module for the coverage_capture, gcov_dump_capture, save_perf_result, and related helpers from conftest.py. This suite mocks dependencies and tests fixture logic without requiring hardware or pytest-embedded.
Refactoring and Expansion of runtime_table_generator.py Tests:
Moves and renames the test file from .github/scripts/test_runtime_table_generator.py to .github/scripts/ci_testing/test_runtime_table_generator.py, updating all references and usage instructions accordingly.
Refactors the test runner logic to return both the cached and full saved test results, enabling more thorough assertions.
Updates all test cases to use the new return signature from run_generator, ensuring compatibility and clarity. [1][2][3][4][5][6][7][8][9]
New Coverage Badge Test Cases:
Adds new test case descriptions and logic to cover various coverage badge scenarios, including boundary values, rounding, and absence of coverage data. [1][2][3]
Path and Import Robustness Improvements:
Updates script path resolution to be more robust and compatible with the new directory structure.
These changes collectively improve the reliability and coverage of the CI test scripts and ensure that future changes to test fixtures and runtime table generation logic are well-tested.
This PR seems to be quite large (total lines of code: 4101), you might consider splitting it into smaller PRs
👋 Hello lucasssvaz, we appreciate your contribution to this project!
📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.
DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.
Please consider the following: - Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes. - Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues. - Addressing info messages (📖) is strongly recommended; they're less critical but valuable. - To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.
Review and merge process you can expect ...
We do welcome contributions in the form of bug reports, feature requests and pull requests.
1. An internal issue has been created for the PR, we assign it to the relevant engineer. 2. They review the PR and either approve it or ask you for changes or clarifications. 3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing. - At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation. 4. If the change is approved and passes the tests it is merged into the default branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
This pull request introduces a new test suite for the
conftest.pyfixtures and expands and refactors the existing test suite forruntime_table_generator.py. The changes improve test coverage, add new test cases (especially for coverage badge logic), and enhance test robustness and maintainability. The most important changes are:New Test Suite for conftest.py Fixtures:
.github/scripts/ci_testing/test_conftest_fixtures.py, a comprehensive test module for thecoverage_capture,gcov_dump_capture,save_perf_result, and related helpers fromconftest.py. This suite mocks dependencies and tests fixture logic without requiring hardware or pytest-embedded.Refactoring and Expansion of runtime_table_generator.py Tests:
.github/scripts/test_runtime_table_generator.pyto.github/scripts/ci_testing/test_runtime_table_generator.py, updating all references and usage instructions accordingly.run_generator, ensuring compatibility and clarity. [1] [2] [3] [4] [5] [6] [7] [8] [9]New Coverage Badge Test Cases:
Path and Import Robustness Improvements:
These changes collectively improve the reliability and coverage of the CI test scripts and ensure that future changes to test fixtures and runtime table generation logic are well-tested.
Test Scenarios
Tested locally
Related links
Requires espressif/pytest-embedded#420