ci: escape regex metacharacters in baseline links for .lycheeignore#744
Merged
f-hollow merged 1 commit intoJun 12, 2026
Merged
Conversation
Baseline links are appended verbatim to .lycheeignore, whose lines
lychee parses as regexes. A baseline URL containing regex
metacharacters aborts the whole check with a parse error before any
link is verified — currently triggered by the provisioning QR-code URL
(`qrcode.html?data={%22ver%22...}`) in content/blog/2026/05/
simple-provisioning, which fails the blog_0-9a-f bucket for every PR.
Escape the metacharacters so baseline URLs match literally.
8 tasks
Member
|
@f-hollow, PTAL. |
f-hollow
approved these changes
Jun 12, 2026
f-hollow
left a comment
Collaborator
There was a problem hiding this comment.
I tested your changes. Now the issue of broken links reported from non-PR changes is gone!
Thank you very much for digging into it!
LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
pr-check-linksworkers append the baseline link dump verbatim to.lycheeignore, whose lines lychee parses as regexes. Any baseline URL containing regex metacharacters aborts the whole check with a parse error before a single link is verified.This is live on
maintoday: the provisioning QR-code URL incontent/blog/2026/05/simple-provisioning/(qrcode.html?data={%22ver%22...}) contains{...}, which lychee rejects as an invalid repetition quantifier:As a result, every PR whose diff touches the
blog_0-9a-fbucket currently failscheck-linksregardless of its own links (seen on #742, whereblog_0-9a-ffails andblog_g-zpasses).The fix escapes regex metacharacters in the baseline dump before appending, so baseline URLs match literally.
Related
Testing
Verified the sed transform on the offending URL:
which is a valid regex matching the URL literally.