fix(websocket): Fix stale CLOSE_FRAME_SENT_BIT blocking PINGs after reconnect#1018
Open
gabsuren wants to merge 2 commits into
Open
fix(websocket): Fix stale CLOSE_FRAME_SENT_BIT blocking PINGs after reconnect#1018gabsuren wants to merge 2 commits into
gabsuren wants to merge 2 commits into
Conversation
|
You have run out of free Bugbot PR reviews for this billing cycle. This will reset on March 20. To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial. |
5 tasks
gabsuren
force-pushed
the
fix/ws_close_on_auto_reconnect_on_close
branch
3 times, most recently
from
070f35d to
b5c54b7
Compare
bryghtlabs-richard
approved these changes
Feb 27, 2026
bryghtlabs-richard
left a comment
bryghtlabs-richard
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me. Should I close #999 since this includes both commits?
Collaborator
Author
Thank you. No worries about the second one. I’ll close it once this one gets merged |
gabsuren
changed the title
If auto-reconnect-on-close is configured, just close the current connection. Do not try to stop the client.
gabsuren
force-pushed
the
fix/ws_close_on_auto_reconnect_on_close
branch
from
b5c54b7 to
a9e032e
Compare
gabsuren
force-pushed
the
fix/ws_close_on_auto_reconnect_on_close
branch
from
a9e032e to
11299ed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related #999
Only set CLOSE_FRAME_SENT_BIT when send_close() succeeds; clear it on every
INIT->CONNECTED transition so a reconnected connection always sends PINGs normally.
Also document the auto_reconnect/close_reconnect dependency in config struct.