feat(lws): bump submodule for mbedTLS 4 support; allow IDF v6.0#1070
feat(lws): bump submodule for mbedTLS 4 support; allow IDF v6.0#1070vikramdattu wants to merge 1 commit into
Conversation
|
Hi @david-cermak — heads up on the clang-tidy failure: it's not the At the SHA we pin ( I've filed the upstream fix: warmcat/libwebsockets#3597. Two paths:
Which do you prefer? |
231032f to
98a9ac5
Compare
Both options are fine with me. If the upstream fix gets merged within days, I would wait. |
| @@ -1,5 +1,5 @@ | |||
| version: "4.3.3~1" | |||
| version: "4.3.3~2" | |||
There was a problem hiding this comment.
@david-cermak the version and the changelog above will pick the commit title automatically?
There was a problem hiding this comment.
@vikramdattu see https://github.com/espressif/esp-protocols/blob/master/CONTRIBUTING.md#release-process
the commit (when created by the bump command) will update the version files and changelog (based on commit delta from the previous tag)
There was a problem hiding this comment.
when created by the bump command
but that doesn't support these ~postfix numbers (yet), so you'd need to edit the commit.
Here's an example #1071
PS: If you like, we can merge #1071 to release v4.3.3~2 for now, and after the upstream maintainers fix the above, we can merge this one to release v4.3.3~3
|
Rebase needed once warmcat/libwebsockets#3600 and warmcat/libwebsockets#3601 and warmcat/libwebsockets#3602 are merged |
Pin the libwebsockets submodule at warmcat main (mbedTLS 4 + the FreeRTOS/ESP-IDF v6 build fixes), allow IDF v6.0, and force lws's mbedTLS 4 code path on IDF: lws's own V4 probe doesn't run on FreeRTOS, so detect the version from the IDF mbedtls component and inject the tf-psa-crypto include dirs.
c144d26 to
617e107
Compare
Summary
1` → `4.3.32`.Verification
Notes