Skip to content

fix: backward-compat for ESM etherpad #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SamTV12345 merged 2 commits into from
May 25, 2026
+39 −15
Merged

fix: backward-compat for ESM etherpad #107

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
71824bb
fix: backward-compat for ESM etherpad
SamTV12345 May 25, 2026
e99b867
fix: guard client-side hooks against timeslider / partial-init contexts
SamTV12345 May 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

const {template} = require('ep_plugin_helpers');

const eejs = require('ep_etherpad-lite/node/eejs/');
const eejs = require('ep_etherpad-lite/node/eejs');

@qodo-free-for-open-source-projects qodo-free-for-open-source-projects Bot May 25, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Action required

1. No regression test for eejs require 📘 Rule violation ☼ Reliability

This PR changes the eejs require path as a bug fix/compatibility fix but does not add or update
any automated regression test that would fail before the change and pass after it. This increases
the risk of reintroducing the trailing-slash issue or missing related resolution regressions.
Agent Prompt 
## Issue description
A bug fix was merged without an accompanying regression test.

## Issue Context
The PR fixes ESM compatibility by removing the trailing slash from the `eejs` require path, but no automated test was added/updated to prevent regressions.

## Fix Focus Areas
- index.js[3-6]
- package.json[25-28]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

const settings = require('ep_etherpad-lite/node/utils/Settings');

exports.loadSettings = (hookName, context, cb) => {
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"description": "Adds inline toolbar support to a Pad",
"name": "ep_inline_toolbar",
"version": "0.2.57",
"version": "0.2.58",
"author": {
"name": "John McLear",
"email": "john@mclear.co.uk"
Expand Down
Loading