fix: disable ANSI colors in history list when stdout is not a TTY - #777
Merged
Conversation
added 2 commits
July 14, 2026 13:14
slapec93
requested changes
Jul 14, 2026
slapec93
left a comment
Collaborator
There was a problem hiding this comment.
Provide some tests for the new functionality please, otherwise LGTM 👌
Comment on lines
+31
to
+32
| head: useColors ? ['green', 'bold'] : [], | ||
| border: useColors ? ['grey'] : [], |
Collaborator
There was a problem hiding this comment.
can you please cover the isTTY = false case with spec(s)?
Contributor
Author
There was a problem hiding this comment.
Added tests to history.spec.ts file
Cafe137
marked this pull request as ready for review
August 11, 2026 13:28
slapec93
reviewed
Aug 12, 2026
slapec93
left a comment
Collaborator
There was a problem hiding this comment.
Just one more suggested improvement, I'm okay without it
| import { getStampOption } from '../utility/stamp' | ||
| import colors from '@colors/colors/safe' | ||
|
|
||
| const ANSI_PATTERN = /\u001B\[\d+m/ //adding this for testing the ansi disable part |
Collaborator
There was a problem hiding this comment.
total nit picking, but since this one is only related to the test cases L131-L166, I would move this const to that block
Contributor
|
Cafe137
approved these changes
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.