Repository navigation
fix(api): trim token from environment before hashing - #53
Merged
Merged
Conversation
Contributor
|
Merged thk's |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ApiToken::resolve hashed the raw env value while the request side trims the Bearer token, so a trailing newline (files, shells) made a valid token always 401. Now the env value is trimmed before the length check and hashing, matching request behavior. New unit test proven to fail before. Verified: fmt, clippy lib+bins exit 0, lib 29/29 plus api/agent/providers suites green. Note: cargo clippy --all-targets currently fails on Windows for a pre-existing dead_code in tests/security.rs (unix-gated callers), untouched here; Linux CI unaffected. I have read and agree to the Contributor Licence Agreement in CLA.md.