Repository navigation
fix(tools): reject non-string fetch_url method and headers - #54
Merged
Merged
Conversation
Contributor
|
Merged thk's |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A numeric method silently became GET and non-string header values were silently dropped, while sibling tools bail on mistyped arguments and the callers believe what they sent. Now present-but-non-string method/headers are explicit errors; valid inputs behave exactly as before. New unit test proven to fail before (old code went to the network). Verified: fmt, clippy lib+bins exit 0, lib + agent suites green. Note: clippy --all-targets fails on Windows for a pre-existing dead_code in tests/security.rs (unix-gated callers), untouched here. I have read and agree to the Contributor Licence Agreement in CLA.md.