fix: raise error when auth login remote URL is missing - #3
Closed
euxaristia wants to merge 1 commit into
Closed
Conversation
Avoid a silent/hanging failure when running 'lore auth login' without a remote URL argument or configured repository remote. Add CLI-side validation and comprehensive unit tests to ensure a clear error is printed to the user. Signed-off-by: euxaristia <euxaristia@users.noreply.github.com>
📝 WalkthroughWalkthroughAdds a Login Remote URL Resolution and Validation
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@lore-client/src/cli/commands/auth.rs`:
- Line 41: The LOGIN_REMOTE_REQUIRED message in auth.rs should include the
token-login fallback so users without a remote know the valid remediation.
Update the error path used by the auth command, including the logic around the
token-login branch in the authenticate flow, to mention `--auth-url` alongside
the existing remote URL or repository remote guidance. Make sure the message
still fits both the normal login path and the `--token-type`/`--token` path
handled by the auth command’s login/authentication code.
In `@lore/src/auth.rs`:
- Line 33: The shared missing-remote message in auth handling is too generic for
the guard that accepts either remote_url or auth_url. Update the token-related
branch in lore/src/auth.rs to use a token-specific missing-endpoint message
instead of LOGIN_REMOTE_REQUIRED, so callers are told auth_url is also an
acceptable fix; keep the same behavior for the existing remote URL path and
adjust the other referenced occurrence as well.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: ec81e558-add1-4197-86ed-7b6827d792d1
📒 Files selected for processing (2)
lore-client/src/cli/commands/auth.rslore/src/auth.rs
| use crate::styling::CommonStyles; | ||
| use crate::util; | ||
|
|
||
| const LOGIN_REMOTE_REQUIRED: &str = "No remote URL supplied. Run `lore auth login <remote-url>` or run from a Lore repository with a configured remote."; |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Include the token-login --auth-url remediation in this error path.
Lines 149-150 intentionally allow token login without a remote when explicit --auth-url is present, but Line 41 only tells users to provide a remote URL or repo config. For --token-type/--token users missing --auth-url, the error omits a valid fix.
Suggested adjustment
const LOGIN_REMOTE_REQUIRED: &str = "No remote URL supplied. Run `lore auth login <remote-url>` or run from a Lore repository with a configured remote.";
+const LOGIN_TOKEN_REMOTE_OR_AUTH_URL_REQUIRED: &str =
+ "No remote URL or auth URL supplied. Run `lore auth login <remote-url>` or pass `--auth-url` for token login outside a Lore repository.";
@@
- Err(LOGIN_REMOTE_REQUIRED)
+ if args.token_type.is_some() && args.token.is_some() {
+ Err(LOGIN_TOKEN_REMOTE_OR_AUTH_URL_REQUIRED)
+ } else {
+ Err(LOGIN_REMOTE_REQUIRED)
+ }Also applies to: 149-153
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@lore-client/src/cli/commands/auth.rs` at line 41, The LOGIN_REMOTE_REQUIRED
message in auth.rs should include the token-login fallback so users without a
remote know the valid remediation. Update the error path used by the auth
command, including the logic around the token-login branch in the authenticate
flow, to mention `--auth-url` alongside the existing remote URL or repository
remote guidance. Make sure the message still fits both the normal login path and
the `--token-type`/`--token` path handled by the auth command’s
login/authentication code.
| use crate::call_delegation::dispatch_call; | ||
| use crate::interface::LoreString; | ||
|
|
||
| const LOGIN_REMOTE_REQUIRED: &str = "No remote URL supplied. Run `lore auth login <remote-url>` or run from a Lore repository with a configured remote."; |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Use a token-specific missing-endpoint error here.
This guard accepts either remote_url or auth_url, but the shared message only says the remote URL is missing. Return a token-specific message so API/CLI callers know auth_url is also a supported fix.
Suggested adjustment
const LOGIN_REMOTE_REQUIRED: &str = "No remote URL supplied. Run `lore auth login <remote-url>` or run from a Lore repository with a configured remote.";
+const LOGIN_TOKEN_REMOTE_OR_AUTH_URL_REQUIRED: &str =
+ "No remote URL or auth URL supplied. Provide a remote URL, configured repository remote, or auth_url for token login.";
@@
- return Err(LoginError::internal(LOGIN_REMOTE_REQUIRED));
+ return Err(LoginError::internal(LOGIN_TOKEN_REMOTE_OR_AUTH_URL_REQUIRED));Also applies to: 214-215
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@lore/src/auth.rs` at line 33, The shared missing-remote message in auth
handling is too generic for the guard that accepts either remote_url or
auth_url. Update the token-related branch in lore/src/auth.rs to use a
token-specific missing-endpoint message instead of LOGIN_REMOTE_REQUIRED, so
callers are told auth_url is also an acceptable fix; keep the same behavior for
the existing remote URL path and adjust the other referenced occurrence as well.
Owner
Author
|
Closing in favor of upstream PR EpicGames#84. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid a silent/hanging failure when running
lore auth loginwithout a remote URL argument or configured repository remote.lore-client/src/cli/commands/auth.rs.lore/src/auth.rsfor non-interactive login paths.Summary by CodeRabbit