Skip to content

gigasecond: use PlainDateTime - #2176

Merged
senekor merged 1 commit into
mainfrom
senekor/otmoqskwwvtm
Nov 1, 2026
Merged

senekor merged 1 commit into
mainfrom
senekor/otmoqskwwvtm

Conversation

@senekor

@senekor senekor commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

PrimitiveDateTime is now a type alias for PlainDateTime. While the
former is not officially deprecated yet, it's good to use the canonical
name proactively.

Forum topic:
https://forum.exercism.org/t/replace-primitivedatetime-with-plaindatetime-time-crate-modernization/74912

[no important files changed]

PrimitiveDateTime is now a type alias for PlainDateTime. While the
former is not officially deprecated yet, it's good to use the canonical
name proactively.
@github-actions

github-actions Bot commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

@senekor senekor added the ready-to-translate The English in this PR is final; queue its translations label Oct 8, 2026
exercism-i18n Bot added a commit to exercism/i18n that referenced this pull request Oct 8, 2026
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@exercism-i18n

exercism-i18n Bot commented Oct 8, 2026

Copy link
Copy Markdown

This PR has been translated 🚀

@senekor
senekor requested a review from ellnix October 8, 2026 20:27
@IsaacG

IsaacG commented Oct 23, 2026

Copy link
Copy Markdown
Member

+cc @exercism/roc

@senekor

senekor commented Oct 23, 2026

Copy link
Copy Markdown
Contributor Author

@IsaacG is that tag a mistake? Not sure why the Roc track maintainers would be interested in this.

@IsaacG

IsaacG commented Oct 23, 2026

Copy link
Copy Markdown
Member

Yes. Apologies. That should be @exercism/rust

@senekor

senekor commented Oct 23, 2026

Copy link
Copy Markdown
Contributor Author

Ah, I see. The Rust track maintainers are just me and @ellnix at the moment anyway.

@ellnix ellnix left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No remaining references to PrimitiveDateTime that I can see, also verified that it's a type alias that their own documentation recommends against using.

LGTM!

@senekor
senekor merged commit 37fbf8b into main Nov 1, 2026
17 of 18 checks passed
@senekor
senekor deleted the senekor/otmoqskwwvtm branch November 1, 2026 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-translate The English in this PR is final; queue its translations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants