[steps][create-eas-build-function] Declare missing dependencies#3798
Open
pataar wants to merge 1 commit into
Open
[steps][create-eas-build-function] Declare missing dependencies#3798pataar wants to merge 1 commit into
pataar wants to merge 1 commit into
Conversation
`fast-glob` and `arg` were imported but not declared in their packages, resolving only via workspace hoisting. Declare them explicitly so the packages keep working when installed standalone.
|
Subscribed to pull request
Generated by CodeMention |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
@expo/stepsimportsfast-glob(inBuildStepContext.ts) andcreate-eas-build-functionimportsarg(incli.tsandutils/args.ts), but neither package declares those dependencies in itspackage.json. Today they resolve through workspace hoisting, so everything works locally — but the packages would break when installed standalone, where hoisting doesn't help.This is the same class of issue as #3741 (which added a direct
debugdependency for similar reasons).How
packages/steps: added"fast-glob": "^3.3.2"todependencies(matches@expo/build-tools).packages/create-eas-build-function: added"arg": "^5.0.2"todevDependencies, following the convention there where ncc-bundled runtime libs (chalk,ora,prompts,fs-extra, …) live under devDependencies.I also audited the rest of the monorepo with
depcheck. Other "missing" hits were either type-only imports backed by ambient declarations (metro-config,xcode,@expo/app-store) or transitive false positives (@jest/typesviajest), so no additional changes were needed.Test Plan
yarn installsucceeds with no new warnings.pnpx depcheckin both packages no longer reports the missing deps.yarn typecheckpasses across all 13 packages./changelog-entry chore Declare
fast-globin@expo/stepsandargincreate-eas-build-function.