[eas-cli] Add eas update:embedded:delete command#3809
Open
gwdp wants to merge 1 commit into
Open
Conversation
5715a11 to
355534b
Compare
355534b to
16db802
Compare
16db802 to
e64f180
Compare
70b98a5 to
2a26d11
Compare
8af87f7 to
837e430
Compare
2a26d11 to
6a8ec9b
Compare
2ec9e9b to
31c9934
Compare
6a8ec9b to
cb942a4
Compare
6cda7eb to
fbc32bb
Compare
cb942a4 to
1afdcb6
Compare
fe90359 to
487dd88
Compare
18725db to
c4c2533
Compare
487dd88 to
db47b12
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## gwdp/embedded-update-list-cmd-v2 #3809 +/- ##
====================================================================
+ Coverage 58.00% 58.03% +0.04%
====================================================================
Files 916 917 +1
Lines 39724 39757 +33
Branches 8318 8322 +4
====================================================================
+ Hits 23036 23069 +33
Misses 15237 15237
Partials 1451 1451 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
c4c2533 to
193818c
Compare
0ae1993 to
6fab55a
Compare
193818c to
d02caa1
Compare
672ccb5 to
fea13d8
Compare
fea13d8 to
e8ec986
Compare
d02caa1 to
c8b8994
Compare
|
✅ Thank you for adding the changelog entry! |
|
Subscribed to pull request
Generated by CodeMention |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Lets users delete an embedded update from the CLI. Pairs with expo/universe#27767. Ref ENG-21466.
How
Confirmation prompt unless
--non-interactive;--jsonround-trips{ id }. Server-side delete is best-effort (idempotent on unknown id), so the CLI succeeds whether or not the id existed.Test Plan
--json, idempotent on unknown id, unexpected rethrow, prompt copy, cancel logging, id passthrough,--json + --non-interactive.yarn start:staging