Skip to content

[eas-cli] Add eas update:embedded:delete command#3809

Open
gwdp wants to merge 1 commit into
gwdp/embedded-update-list-cmd-v2from
gwdp/embedded-update-delete-cmd
Open

[eas-cli] Add eas update:embedded:delete command#3809
gwdp wants to merge 1 commit into
gwdp/embedded-update-list-cmd-v2from
gwdp/embedded-update-delete-cmd

Conversation

@gwdp
Copy link
Copy Markdown
Contributor

@gwdp gwdp commented May 29, 2026

Why

Lets users delete an embedded update from the CLI. Pairs with expo/universe#27767. Ref ENG-21466.

How

Confirmation prompt unless --non-interactive; --json round-trips { id }. Server-side delete is best-effort (idempotent on unknown id), so the CLI succeeds whether or not the id existed.

Test Plan

  • unit tests cover confirm-path, non-interactive, abort, --json, idempotent on unknown id, unexpected rethrow, prompt copy, cancel logging, id passthrough, --json + --non-interactive.
  • Local CLI against universe yarn start:staging
Screenshot 2026-06-02 at 11 36 53 PM

@gwdp gwdp force-pushed the gwdp/embedded-update-delete-cmd branch from 5715a11 to 355534b Compare June 2, 2026 23:07
@linear
Copy link
Copy Markdown

linear Bot commented Jun 2, 2026

ENG-21466

@gwdp gwdp force-pushed the gwdp/embedded-update-delete-cmd branch from 355534b to 16db802 Compare June 3, 2026 05:13
@gwdp gwdp changed the base branch from main to gwdp/embedded-update-list-cmd-v2 June 3, 2026 05:13
@gwdp gwdp force-pushed the gwdp/embedded-update-delete-cmd branch from 16db802 to e64f180 Compare June 3, 2026 05:51
@gwdp gwdp force-pushed the gwdp/embedded-update-list-cmd-v2 branch from 70b98a5 to 2a26d11 Compare June 3, 2026 05:51
@gwdp gwdp force-pushed the gwdp/embedded-update-delete-cmd branch 2 times, most recently from 8af87f7 to 837e430 Compare June 3, 2026 05:56
@gwdp gwdp force-pushed the gwdp/embedded-update-list-cmd-v2 branch from 2a26d11 to 6a8ec9b Compare June 3, 2026 06:24
@gwdp gwdp force-pushed the gwdp/embedded-update-delete-cmd branch 2 times, most recently from 2ec9e9b to 31c9934 Compare June 3, 2026 06:29
@gwdp gwdp force-pushed the gwdp/embedded-update-list-cmd-v2 branch from 6a8ec9b to cb942a4 Compare June 3, 2026 06:34
@gwdp gwdp force-pushed the gwdp/embedded-update-delete-cmd branch 2 times, most recently from 6cda7eb to fbc32bb Compare June 3, 2026 06:54
@gwdp gwdp force-pushed the gwdp/embedded-update-list-cmd-v2 branch from cb942a4 to 1afdcb6 Compare June 3, 2026 06:54
@gwdp gwdp force-pushed the gwdp/embedded-update-delete-cmd branch 2 times, most recently from fe90359 to 487dd88 Compare June 3, 2026 22:01
@gwdp gwdp force-pushed the gwdp/embedded-update-list-cmd-v2 branch 2 times, most recently from 18725db to c4c2533 Compare June 3, 2026 22:16
@gwdp gwdp force-pushed the gwdp/embedded-update-delete-cmd branch from 487dd88 to db47b12 Compare June 3, 2026 22:16
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 58.03%. Comparing base (c8b8994) to head (e8ec986).

Additional details and impacted files
@@                         Coverage Diff                          @@
##           gwdp/embedded-update-list-cmd-v2    #3809      +/-   ##
====================================================================
+ Coverage                             58.00%   58.03%   +0.04%     
====================================================================
  Files                                   916      917       +1     
  Lines                                 39724    39757      +33     
  Branches                               8318     8322       +4     
====================================================================
+ Hits                                  23036    23069      +33     
  Misses                                15237    15237              
  Partials                               1451     1451              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gwdp gwdp force-pushed the gwdp/embedded-update-list-cmd-v2 branch from c4c2533 to 193818c Compare June 3, 2026 22:58
@gwdp gwdp force-pushed the gwdp/embedded-update-delete-cmd branch 2 times, most recently from 0ae1993 to 6fab55a Compare June 3, 2026 23:01
@gwdp gwdp force-pushed the gwdp/embedded-update-list-cmd-v2 branch from 193818c to d02caa1 Compare June 3, 2026 23:01
@gwdp gwdp force-pushed the gwdp/embedded-update-delete-cmd branch 2 times, most recently from 672ccb5 to fea13d8 Compare June 3, 2026 23:35
@gwdp gwdp force-pushed the gwdp/embedded-update-delete-cmd branch from fea13d8 to e8ec986 Compare June 3, 2026 23:55
@gwdp gwdp force-pushed the gwdp/embedded-update-list-cmd-v2 branch from d02caa1 to c8b8994 Compare June 3, 2026 23:55
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 3, 2026

✅ Thank you for adding the changelog entry!

@gwdp gwdp requested a review from quinlanj June 4, 2026 00:04
@gwdp gwdp marked this pull request as ready for review June 4, 2026 00:04
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 4, 2026

Subscribed to pull request

File Patterns Mentions
**/* @douglowder
packages/eas-cli/src/commands/update/** @wschurman, @quinlanj

Generated by CodeMention

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant