[scripts] Add runtime settings editor#3812
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3812 +/- ##
=======================================
Coverage 57.46% 57.46%
=======================================
Files 911 911
Lines 39480 39480
Branches 8271 8271
=======================================
Hits 22684 22684
Misses 15328 15328
Partials 1468 1468 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sjchmiela
force-pushed
the
stanley/edit-runtime-settings
branch
from
4d34a71 to
daa24d9
Compare
sjchmiela
force-pushed
the
stanley/edit-runtime-settings
branch
from
daa24d9 to
4930081
Compare
|
⏩ The changelog entry check has been skipped since the "no changelog" label is present. |
|
Subscribed to pull request
Generated by CodeMention |
| gsutil \ | ||
| -h "Cache-Control:${cache_control}" \ | ||
| -h "Content-Type:application/json" \ | ||
| cp "$minified_tmpfile" "$object_uri" | ||
| gsutil acl ch -u AllUsers:R "$object_uri" |
There was a problem hiding this comment.
its possible we fail after cp and the object remains private. I think we can just do gsutil cp -a public-read ...
| exit 1 | ||
| fi | ||
|
|
||
| for tool in gsutil jq; do |
There was a problem hiding this comment.
I see this on the gsutil docs
Important: gsutil is not the recommended CLI for Cloud Storage. Use gcloud storage commands in the Google Cloud CLI instead.
| cp "$minified_tmpfile" "$object_uri" | ||
| gsutil acl ch -u AllUsers:R "$object_uri" | ||
|
|
||
| curl -fsSL "$object_url" >"$downloaded_tmpfile" |
There was a problem hiding this comment.
can also do
| curl -fsSL "$object_url" >"$downloaded_tmpfile" | |
| gcloud storage cat "$object_uri" >"$downloaded_tmpfile" |
2 participants
I want us to move off of killswitches in Redis coming from
workflow-orchestrationtowards fetching killswitches from a simple JSON file.I picked GCS over R2 because it lets us make objects fully public (no
Authorizationrequired) and I (Stanley) found no way to achieve the same thing with R2.This pull request adds a script
scripts/edit-runtime-settings staging | productionthat is going to let us edit the file.