Skip to content

fix: preserve error details like cause in logerror #7007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jonathan-fulton wants to merge 1 commit into from
Closed

fix: preserve error details like cause in logerror #7007

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion lib/application.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -608,13 +608,17 @@ app.listen = function listen() {
/**
* Log error using console.error.
*
* Logs the full error object to preserve details like `cause` property
* and other custom error properties that would be lost when only
* logging the stack trace.
*
* @param {Error} err
* @private
*/

function logerror(err) {
/* istanbul ignore next */
if (this.get('env') !== 'test') console.error(err.stack || err.toString());
if (this.get('env') !== 'test') console.error(err);
}

/**
Expand Down