fix: logError now logs full error object including cause#7088
Closed
KJyang-0114 wants to merge 1 commit into
Closed
fix: logError now logs full error object including cause#7088KJyang-0114 wants to merge 1 commit into
KJyang-0114 wants to merge 1 commit into
Conversation
Before: console.error(err.stack || err.toString()) After: console.error(err) This preserves error.cause, nested errors, and async stack traces that are lost when using err.stack alone. Fixes expressjs#6462
Contributor
|
Duplicate of #6464 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #6462 -
logErrorswallows error details (such ascause)Problem
Before:
console.error(err.stack || err.toString())After:
console.error(err)The previous code using
err.stackloses important error information:Solution
Change from
err.stack || err.toString()to justerr, which allows the console to properly format and display the full error object including all nested properties.Testing
This fix preserves:
See the original issue for concrete examples.