Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions lib/application.js
Original file line number Diff line number Diff line change
Expand Up @@ -207,6 +207,12 @@ app.use = function use(fn) {
}
}

// normalize all-slash mount paths (e.g. '//', '///') to '/' so they don't
// collapse to '' in the router's loosen() and match every request
if (typeof path === 'string' && /^\/+$/.test(path)) {
path = '/';
}

var fns = flatten.call(slice.call(arguments, offset), Infinity);

if (fns.length === 0) {
Expand Down
41 changes: 41 additions & 0 deletions test/app.use.js
Original file line number Diff line number Diff line change
Expand Up @@ -361,6 +361,47 @@ describe('app', function(){
.expect(200, 'saw POST /bar', cb);
})

it('should treat all-slash paths as a root mount', function (done) {
var app = express();
var sub = express();
var cb = after(4, done);

sub.get('/', function (req, res) {
res.send('sub-root');
});

sub.get('/secret', function (req, res) {
res.send('sub-secret');
});

app.use('//', sub);

request(app)
.get('/')
.expect(200, 'sub-root', cb);

request(app)
.get('/secret')
.expect(200, 'sub-secret', cb);

// unrelated paths must still 404 — '//' must not match every request
request(app)
.get('/missing')
.expect(404, cb);

// '///' (and longer) must normalize to '/' the same way as '//'
var triple = express();
var sub2 = express();
sub2.get('/', function (req, res) {
res.send('triple-root');
});
triple.use('///', sub2);

request(triple)
.get('/')
.expect(200, 'triple-root', cb);
})

it('should accept array of middleware', function (done) {
var app = express();

Expand Down