fix: logError logs full error object including cause (#6462)#7296
Closed
ErnestHysa wants to merge 1 commit into
Closed
fix: logError logs full error object including cause (#6462)#7296ErnestHysa wants to merge 1 commit into
ErnestHysa wants to merge 1 commit into
Conversation
Fixes expressjs#6462 - logError swallows cause Changed console.error(err.stack || err.toString()) to console.error(err) so that the full error including the cause chain is logged properly.
Contributor
|
Duplicate of #6464 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #6462 - logError swallows Error.cause
Changes
In
lib/application.js, changed:to:
Why
When logging
err.stack, theError.cause()chain is lost becausestackonly contains the stack trace of the specific error, not the cause chain. Logging the fullerrobject allows Node.js to print the complete error including thecausechain, making debugging much easier.Testing
npm testpasses for the application.js related tests.