Skip to content

feat: add charset option for multipart forms - #1327

Closed
bjohansebas wants to merge 1 commit into
expressjs:mainfrom
bjohansebas:charset-utf8
Closed

feat: add charset option for multipart forms#1327
bjohansebas wants to merge 1 commit into
expressjs:mainfrom
bjohansebas:charset-utf8

Conversation

@bjohansebas

Copy link
Copy Markdown
Member

Rebase of #1210, and I’m removing the changes to the READMEs since I’d prefer a native speaker to handle them. Although, I still hope to eventually remove the README translations from here.

closes #1104
closes #1210

…-8 filenames

Signed-off-by: Sebastian Beltran <bjohansebas@gmail.com>
@coveralls

Copy link
Copy Markdown

Coverage Status

coverage: 98.491% (+0.01%) from 98.479%
when pulling 139ad8b on bjohansebas:charset-utf8
into 256da2f on expressjs:main.

Comment thread test/unicode.js
var boundary = 'AaB03x'
var body = [
'--' + boundary,
'Content-Disposition: form-data; name="small0"; filename="ÖoϪ.dat"',

@ShubhamOulkar ShubhamOulkar Jun 9, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

   filename="ÖoϪ.dat"',

see #1210 (comment)

@UlisesGascon
UlisesGascon force-pushed the main branch 2 times, most recently from 2ad8b68 to eef7444 Compare August 28, 2026 18:44
@UlisesGascon

Copy link
Copy Markdown
Member

we're keeping busboy's option names as they are in v2. defParamCharset has been public since 2.1.0, and #1465 adds defCharset, highWaterMark and fileHwm under the same rule, so renaming one of them now would mean an alias and a deprecation for the rest of the v2 line for a cosmetic gain. If we want friendlier names, that's a v3 decision for all of them at once.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Issue with UTF-8 characters in filename

4 participants