Skip to content

ci: close stale issues and pull requests - #1470

Open
UlisesGascon wants to merge 2 commits into
mainfrom
chore/stale-workflow
Open

ci: close stale issues and pull requests#1470
UlisesGascon wants to merge 2 commits into
mainfrom
chore/stale-workflow

Conversation

@UlisesGascon

Copy link
Copy Markdown
Member

Adds a daily actions/stale workflow (pinned to v11.0.0), modelled on the one in nodejs/security-wg: issues and pull requests with no activity for 30 days get the stale label and a comment, and are closed after another 30 days unless there is activity or the label is removed.

Exempt labels: security-release, release (issues and PRs), plus help wanted and good first issue (issues), so tracked work is never auto-closed.

@UlisesGascon
UlisesGascon requested a review from a team August 29, 2026 17:50
@UlisesGascon UlisesGascon self-assigned this Aug 29, 2026
@coveralls

coveralls commented Aug 29, 2026

Copy link
Copy Markdown

Coverage Status

coverage: 99.739%. remained the same — chore/stale-workflow into main

@bjohansebas bjohansebas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I don’t oppose this, you’re the captain after all 😄, but I’d personally prefer that we go through the existing issues and review them, then either close them manually or get the PRs merged. It’s been a while since I’ve reviewed them, so I’m not sure what issues are still open, but we can gradually close them as the PRs get merged. Most of them are probably still valid PRs; people just don’t always have the time to dedicate to them, so they end up going stale.

@krzysdz krzysdz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marking issues as stale and closing them usually just shows that nobody had time or cared1 to triage them. I think that this would make sense only for issues/PRs labelled awaiting more info 2. Otherwise it'll just frustrate people and lead to situations like podman-container-tools/buildah#6611 (comment).

An issue that nobody had time to look into may still be valid. A PR with no activity can be picked up later by a maintainer if the author does not respond. Closing things just because they're old is like complaining that some dependencies have not received updates in a long time (even if there is nothing to update).

Personally, I don't think I've ever checked multer's issues and pull requests. I have never used it and there seems to be some activity here (security advisories), so I thought that someone is taking care of it. Although I'm against stale bots in general, I won't oppose this strongly, because I don't really help here either.

Footnotes

  1. Recently I've been ignoring a significant part of PRs (and issues) created using AI in other repos, because it's just no fun, bots (and possibly human meat proxies) don't understand things, there are lots of duplicates (I often close duplicates if skimming the title is enough to recognise them), usefulness of some PRs is dubious (though formatting-only PRs have been opened by people since forever), descriptions are super long, extremely verbose and sometimes partially wrong, and these things are just way harder to review/understand/triage than real human communication.

  2. Labelled, so somebody must have checked it and decided that it requires the author's attention - something is not clear and/or it can't be reproduced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants