allow file upload without filename - #693
Open
warncke wants to merge 1 commit into
Open
Conversation
Member
|
Hmmm, do you think that this should be a breaking change? 🤔 I'm guessing yes maybe? 🤔 |
Author
|
i don't have a good answer on this. it does change the behavior significantly, but it applies to a very narrow set of cases, and it makes the behavior more consistent with the specs, so not sure how you classify it. at the end of the day i don't think many people are encountering this issue or it would have been raised before so probably best to err on the side of caution and not breaking anything for existing users. |
UlisesGascon
force-pushed
the
main
branch
2 times, most recently
from
August 28, 2026 18:44
2ad8b68 to
eef7444
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an edge case where a client is sending an upload request without a filename but with the content type of application/octet-stream so it gets silently ignored.
Per the spec filename is not required (https://tools.ietf.org/html/rfc1867) so even if this is a rare case it seems reasonable to allow.