refactor(order): InboxEvent eventId → eventKey 통일 [KAN-249]#36
Open
lian2945 wants to merge 5 commits into
Open
refactor(order): InboxEvent eventId → eventKey 통일 [KAN-249]#36lian2945 wants to merge 5 commits into
lian2945 wants to merge 5 commits into
Conversation
…ype 전파 [KAN-215] - ProductType enum 신규 (RELEASE, GENERAL_GOODS) - OrderLine 도메인에 productType 필드 추가 (createBuilder, reconstructBuilder) - OrderLineEntity에 product_type 컬럼 추가 (@Enumerated STRING) - OrderMapper toLineEntity/toLineDomain에 productType 매핑 추가 - OrderPrepareEvent.OrderItemPayload에 product_type 필드 추가 - CreateOrderCommand.OrderLineCommand에 productType 추가 - OrderLineRequest에 productType 추가 (validation 포함) - CreateOrderService: command에서 productType 전달 - CreateReleaseOrderService: ProductType.RELEASE 하드코딩 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- OrderLine 도메인, OrderLineEntity에 thumbnailUrl 필드 추가 - 주문 생성 요청(CreateOrderRequest, CreateReleaseOrderRequest, OrderLineRequest)에 thumbnailUrl 수신 - CreateOrderCommand, CreateReleaseOrderCommand에 thumbnailUrl 전달 - CreateOrderService, CreateReleaseOrderService에서 OrderLine 생성 시 thumbnailUrl 세팅 - OrderMapper toLineEntity/toLineDomain에 thumbnailUrl 매핑 - OrderResultMapper, OrderLineResult, OrderLineResponse에 thumbnailUrl 포함 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- ReadNotificationCommand: notificationId → notificationIds(List<Long>)로 변경 - ReadNotificationUseCase: read() → readAll()로 변경 - ReadNotificationService: updateAllByIdsAndUserId 단일 쿼리로 일괄 처리 - NotificationJpaRepository: @Modifying bulk UPDATE 쿼리 추가 - NotificationJpaAdapter: updateAllByIdsAndUserId 구현 - NotificationCommandController: PATCH /{id}/read → PATCH /read (body: notificationIds) - ReadNotificationsRequest: 신규 request DTO 추가 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…규칙 추가 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- InboxEvent 인터페이스에서 Long eventId() 제거, occurredAt()만 유지 - 이벤트 레코드 7개(Stock/Payment/Delivery 관련)에서 event_id 필드 제거 - OrderInboxEntity: eventId(Long) → eventKey(String, event_key 컬럼) - OrderInboxJpaRepository: existsByEventId → existsByEventKey (derived query) - IdempotentAspect: consumerRecord.key() 기반으로 변경, null 시 topic-partition-offset fallback Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
관련 이슈
KAN-249
변경 사항 요약
InboxEvent인터페이스에서Long eventId()제거,occurredAt()만 유지StockReserveSucceededEvent,StockReserveFailedEvent,PaymentSucceededEvent,PaymentFailedEvent,PaymentCancelSucceededEvent,PaymentCancelFailedEvent,DeliveryStartedEvent,DeliveryCompletedEvent)에서event_id필드 제거OrderInboxEntity:eventId(Long) →eventKey(String,event_key컬럼)로 변경OrderInboxJpaRepository:existsByEventId→existsByEventKey(derived query)IdempotentAspect:consumerRecord.key()기반으로 변경, null 시topic-partition-offsetfallback 처리테스트 체크리스트