Skip to content

fix(data): align dynamic_bucket kwarg between Python stub and pybind #1510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ace3Z wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(data): align dynamic_bucket kwarg between Python stub and pybind #1510

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion native/python/src/fairseq2n/bindings/data/data_pipeline.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -500,7 +500,7 @@ def_data_pipeline(py::module_ &data_module)
return self;
},
py::arg("threshold"),
py::arg("fn"),
py::arg("cost_fn"),
py::arg("bucket_creation_fn") = std::nullopt,
py::arg("min_num_examples") = std::nullopt,
py::arg("max_num_examples") = std::nullopt,
Expand Down
19 changes: 19 additions & 0 deletions tests/unit/data/data_pipeline/test_dynamic_bucket.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,3 +320,22 @@ def test_op_saves_and_restores_its_state(self) -> None:

with pytest.raises(StopIteration):
next(iter(pipeline))

def test_op_works_when_cost_fn_is_passed_as_kwarg(self) -> None:
# Regression for #1103: the binding used to expose this kwarg as `fn`.
seq = list(range(1, 7))

pipeline = (
read_sequence(seq)
.dynamic_bucket(threshold=6, cost_fn=lambda x: x)
.and_return()
)

it = iter(pipeline)

assert next(it) == [1, 2, 3]
assert next(it) == [4, 5]
assert next(it) == [6]

with pytest.raises(StopIteration):
next(it)