Skip to content

Fix: make default ProjectDTO.page null#413

Closed
florimondmanca wants to merge 1 commit into
masterfrom
fix/all-projects-dto-null
Closed

Fix: make default ProjectDTO.page null#413
florimondmanca wants to merge 1 commit into
masterfrom
fix/all-projects-dto-null

Conversation

@florimondmanca
Copy link
Copy Markdown
Contributor

WAHIS (le 31e projet) ne s'affichait toujours pas

En fait, il fallait que la valeur par défaut de page dans le DTO passe aussi à null... Sinon pour l'instant le select requête toujours l'équivalent de /projects?page=1

@florimondmanca florimondmanca force-pushed the fix/all-projects-dto-null branch from a66c8e9 to 5f522d6 Compare October 17, 2023 13:42
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 17, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (16eb791) 91.49% compared to head (5f522d6) 91.49%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #413   +/-   ##
=======================================
  Coverage   91.49%   91.49%           
=======================================
  Files         207      207           
  Lines        2422     2422           
  Branches      146      146           
=======================================
  Hits         2216     2216           
  Misses        206      206           
Files Coverage Δ
...erver/src/Infrastructure/Project/DTO/FiltersDTO.ts 87.50% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@florimondmanca florimondmanca changed the title Fix: default project DTO.page should be null Fix: default ProjectDTO.page should be null Oct 23, 2023
@florimondmanca florimondmanca changed the title Fix: default ProjectDTO.page should be null Fix: make default ProjectDTO.page null Oct 23, 2023
@florimondmanca
Copy link
Copy Markdown
Contributor Author

C'est réglé par #415

@florimondmanca florimondmanca deleted the fix/all-projects-dto-null branch February 7, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant