Make scale point patch for LV2 compatible across versions.#2049
Open
kramlie wants to merge 4 commits into
Open
Make scale point patch for LV2 compatible across versions.#2049kramlie wants to merge 4 commits into
kramlie wants to merge 4 commits into
Conversation
Previously it was only available when running as a Jack application. Signed-off-by: Kristian Amlie <kristian@amlie.name>
Signed-off-by: Kristian Amlie <kristian@amlie.name>
Signed-off-by: Kristian Amlie <kristian@amlie.name>
Use a dedicated `PARAMETER_SCALEPOINT_COUNT` statement in the protocol, so that old versions ignore it, instead of getting out of sync with the protocol and failing altogether. This helps for example to run an updated Carla and an older Carla-inside-Cardinal side by side. Signed-off-by: Kristian Amlie <kristian@amlie.name>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is based on #2020, but contains additional compatibility code for that feature.
Use a dedicated
PARAMETER_SCALEPOINT_COUNTstatement in the protocol, so that old versions ignore it, instead of getting out of sync with the protocol and failing altogether.This helps for example to run an updated Carla and an older Carla-inside-Cardinal side by side.
I submitted this separately from #2020 so it could be decided whether this is necessary or not. It is definitely nice to have as long as #2020 is not merged into mainline, at least.