Fix settings loading mismatch between the plugin list and config dialog.#2050
Open
kramlie wants to merge 1 commit into
Open
Fix settings loading mismatch between the plugin list and config dialog.#2050kramlie wants to merge 1 commit into
kramlie wants to merge 1 commit into
Conversation
The `loadSettings` function in carla_host.py was not loading settings using the same logic as the config dialog, which means that in case of running as a plugin, some settings, such as plugin paths, had no effect on the plugins listed in the plugin selection dialog. This had some weird effects such as: If you loaded a plugin from some standard location, then moved the plugin to a nonstandard location and updated the path in the config, the project containing that plugin could still be loaded, despite the plugin not existing in the plugin list! Again, this is because the loading and the listing used different logic to load the path settings. Signed-off-by: Kristian Amlie <kristian@amlie.name>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
loadSettingsfunction in carla_host.py was not loading settings using the same logic as the config dialog, which means that in case of running as a plugin, some settings, such as plugin paths, had no effect on the plugins listed in the plugin selection dialog.This had some weird effects such as: If you loaded a plugin from some standard location, then moved the plugin to a nonstandard location and updated the path in the config, the project containing that plugin could still be loaded, despite the plugin not existing in the plugin list! Again, this is because the loading and the listing used different logic to load the path settings.