fix: respect TYPER_USE_RICH in completion help text (fixes #1643)#1818
Closed
mshzy wants to merge 1 commit into
Closed
fix: respect TYPER_USE_RICH in completion help text (fixes #1643)#1818mshzy wants to merge 1 commit into
mshzy wants to merge 1 commit into
Conversation
_sanitize_help_text checked if Rich is installed but ignored the TYPER_USE_RICH=false environment variable. When users disable Rich, the completion system would still try to import and use it. Fixes fastapi#1643.
svlandeg
reviewed
Jun 2, 2026
Member
svlandeg
left a comment
svlandeg
left a comment
There was a problem hiding this comment.
#1643 is a PR. Usually you use "fixes XXX" when XXX is an issue or a discussion.
If there's already a PR, please provide more information on why the existing solution is not adequate. You can do so by leaving a review on that PR. I'll close this one to avoid duplicate threads.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1643: _sanitize_help_text now checks TYPER_USE_RICH env var