Skip to content

🐛 Respect wait=False when launching URLs with xdg-open#1820

Merged
tiangolo merged 1 commit into
masterfrom
2026-06-02-respect-wait-false-when-launching-urls-with-xdg-op
Jun 3, 2026
Merged

🐛 Respect wait=False when launching URLs with xdg-open#1820
tiangolo merged 1 commit into
masterfrom
2026-06-02-respect-wait-false-when-launching-urls-with-xdg-op

Conversation

@patrick91
Copy link
Copy Markdown
Contributor

@patrick91 patrick91 commented Jun 2, 2026

Stack

@patrick91 patrick91 added the bug Something isn't working label Jun 2, 2026
@patrick91 patrick91 marked this pull request as ready for review June 2, 2026 11:53
@svlandeg svlandeg assigned svlandeg and unassigned svlandeg Jun 2, 2026
@svlandeg
Copy link
Copy Markdown
Member

svlandeg commented Jun 2, 2026

@patrick91 : the coverage check is still failing here, are you looking into it?

@patrick91 patrick91 force-pushed the 2026-06-02-respect-wait-false-when-launching-urls-with-xdg-op branch from 57c4a55 to 7217cd9 Compare June 2, 2026 13:36
@patrick91
Copy link
Copy Markdown
Contributor Author

@svlandeg updated 😊

@svlandeg svlandeg self-assigned this Jun 2, 2026
Copy link
Copy Markdown
Member

@svlandeg svlandeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@svlandeg svlandeg removed their assignment Jun 2, 2026
Copy link
Copy Markdown
Member

@tiangolo tiangolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice debugging and fix! Excellent, thank you! 🙌🚀

This will be available in Typer 0.26.7, released in the next few hours. 🎉

@tiangolo tiangolo merged commit 8e75bc3 into master Jun 3, 2026
26 checks passed
@tiangolo tiangolo deleted the 2026-06-02-respect-wait-false-when-launching-urls-with-xdg-op branch June 3, 2026 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants