Skip to content

Match folder icon optical size #7069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ComputelessComputer merged 1 commit into from
Aug 24, 2026
Merged

Match folder icon optical size #7069

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions apps/desktop/src/session/components/folder-picker.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ describe("FolderPicker", () => {
cleanup();
});

it("shows only a standard-sized folder icon when no folder is selected", () => {
it("optically sizes the folder icon when no folder is selected", () => {
render(<FolderPicker sessionId="session-1" />);

const trigger = screen.getByRole("combobox", { name: "Select folder" });
Expand All @@ -41,7 +41,7 @@ describe("FolderPicker", () => {
expect(trigger.textContent).toBe("");
expect(trigger.className).toContain("w-7");
expect(icons).toHaveLength(1);
expect(icons[0]?.getAttribute("class")).toContain("size-4");
expect(icons[0]?.getAttribute("class")).toContain("size-[18px]");
});

it("shows the selected folder name without a chevron", () => {
Expand Down
2 changes: 1 addition & 1 deletion apps/desktop/src/session/components/folder-picker.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ export function FolderPicker({
open && "bg-accent text-foreground",
])}
>
<FolderSimple className="size-4 shrink-0" aria-hidden="true" />
<FolderSimple className="size-[18px] shrink-0" aria-hidden="true" />
{currentPath ? (
<span className="min-w-0 truncate text-xs text-neutral-600 dark:text-neutral-300">
{currentPath}
Expand Down
Loading