Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 24 additions & 1 deletion apps/desktop/src/session/components/outer-header/index.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -499,7 +499,30 @@ describe("OuterHeader", () => {
expect(screen.queryByRole("textbox", { name: "Session title" })).toBeNull();
});

it("hides the title input on the memo tab", () => {
it("shows an editable title on the memo tab before recording", () => {
render(
<OuterHeader
sessionId="session-1"
currentView={{ type: "raw" } as EditorView}
tab={{
active: true,
id: "session-1",
pinned: false,
slotId: "slot-1",
state: { autoStart: null, view: { type: "raw" } },
type: "sessions",
}}
/>,
);

const title = screen.getByRole("textbox", { name: "Session title" });

expect(title.getAttribute("placeholder")).toBe("Untitled");
});

it("hides the title input on the memo tab after recording", () => {
mocks.hasTranscriptBySession = { "session-1": true };

render(
<OuterHeader
sessionId="session-1"
Expand Down
6 changes: 1 addition & 5 deletions apps/desktop/src/session/components/outer-header/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -76,11 +76,7 @@ export function OuterHeader({
sessionMode === "active" || sessionMode === "running_batch";
const isLiveMeeting = isRecording || sessionMode === "finalizing";
const meetingOver = !isRecording && (ended || hasTranscript || audioExists);
const showTitleInput =
Boolean(tab) &&
!isLiveMeeting &&
currentView.type === "enhanced" &&
!meetingOver;
const showTitleInput = Boolean(tab) && !isLiveMeeting && !meetingOver;

return (
<div
Expand Down
Loading