Skip to content

backend: respect disable createrepo when forking project to another #4467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nikromen wants to merge 1 commit into
base: main
Choose a base branch
from
Open

backend: respect disable createrepo when forking project to another #4467

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion backend/copr_backend/storage.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,7 +305,8 @@ def fork_project(self, src_fullname, dst_fullname, builds_map, createrepo=True):
new_chroot_path = os.path.join(new_path, chroot)
ensure_dir_exists(new_chroot_path, self.log)

if createrepo and not call_copr_repo(new_chroot_path, logger=self.log):
if createrepo and not call_copr_repo(new_chroot_path, devel=self.devel,
logger=self.log):

@FrostyX FrostyX Sep 2, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is only for the BackendStorage. I guess we will need the same fix for the PulpStorage as well?

return False
return True

Expand Down
3 changes: 3 additions & 0 deletions frontend/coprs_frontend/coprs/logic/actions_logic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -364,6 +364,9 @@ def send_fork_copr(cls, src, dst, builds_map):
"copr": dst.name,
"builds_map": builds_map,
"storage": src.storage,
"ownername": dst.owner_name,

@praiskup praiskup Sep 3, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious why we need dst.owner_name twice?

@nikromen nikromen Sep 3, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

owner = self.ext_data.get("ownername") in actions.py on line 94 takes it; however not related directly to this fix... but would be nice to fill that value and not having it none

"projectname": dst.name,
"devel": dst.devel_mode,

@praiskup praiskup Sep 3, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bump BE/FE protocol nunber?

@nikromen nikromen Sep 3, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

before doing any follow-up action I want to clarify whether we really want to fix #4461 this way? Or we leave this behavior as is?

To me currently it makes sense to respect disable createrepo of destination fork project (the way how this PR points) however we have not come to clear conclusion, rather that this could be interpreted in numerous ways, so if at the end of the day this is not needed I'd prefer not to touch this and close the issue

}

action = models.Action(
Expand Down