Skip to content

backend: make get_package_by_prn work with Pulp domains - #4482

Merged
praiskup merged 1 commit into
fedora-copr:mainfrom
FrostyX:change-storage-prns-2
Sep 7, 2026
Merged

backend: make get_package_by_prn work with Pulp domains#4482
praiskup merged 1 commit into
fedora-copr:mainfrom
FrostyX:change-storage-prns-2

Conversation

@FrostyX

@FrostyX FrostyX commented Sep 5, 2026

Copy link
Copy Markdown
Member

See #4472

I tested that PR only locally, where Pulp domains are disabled. On STG and production it fails because it tries to query e.g. this:

https://packages.redhat.com/pulp/api/v3/content/rpm/packages/01a05b15-7756-7f24-88f2-f09387e38465/

instead of this:

https://packages.redhat.com/api/pulp/public-copr/api/v3/content/rpm/packages/01a05b15-7756-7f24-88f2-f09387e38465/

@FrostyX

FrostyX commented Sep 5, 2026

Copy link
Copy Markdown
Member Author

/packit test

@coderabbitai

coderabbitai Bot commented Sep 5, 2026

Copy link
Copy Markdown

Review Change Stack

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Team

Run ID: 2e5c7b10-375f-4552-a795-f24b39169d74

📥 Commits

Reviewing files that changed from the base of the PR and between 02850a2 and dad8ba5.

📒 Files selected for processing (1)
  • backend/copr_backend/pulp.py

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.


📝 Walkthrough

Walkthrough

get_package_by_prn() now builds the Pulp package endpoint directly and sends the request through send(). It also logs the constructed URI.

Changes

Pulp package lookup

Layer / File(s) Summary
Direct package request
backend/copr_backend/pulp.py
get_package_by_prn() constructs the package URI, logs it, and replaces get_by_href() with a direct GET request through send().

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to dad8b

Package lookups now use the domain-aware Pulp API route while preserving the existing GET response behavior. No merge-blocking risk is evident.

Suggested reviewers: praiskup

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description check ✅ Passed The description explains the Pulp domain issue, identifies the incorrect and correct URLs, and relates directly to the code change.
Title check ✅ Passed The title clearly identifies the backend change and states that get_package_by_prn must work with Pulp domains.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 1 files.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@praiskup
praiskup merged commit a62bd06 into fedora-copr:main Sep 7, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants