Skip to content

Feature/cdn deps update #131 - #132

Merged
bhoy-troy merged 1 commit into
fedora-eln:masterfrom
bhoy-troy:feature/cdn-deps-update-#131
Aug 27, 2026
Merged

Feature/cdn deps update #131#132
bhoy-troy merged 1 commit into
fedora-eln:masterfrom
bhoy-troy:feature/cdn-deps-update-#131

Conversation

@bhoy-troy

Copy link
Copy Markdown
Collaborator

Bump CDN dependency versions

Bump frontend CDN dependencies in templates/layout.html to their latest versions with updated SRI hashes to ensure secure delivery.

Resolves issues in #131

Summary

  • Update DataTables from 2.3.8 to 3.0.1
  • Update Axios from 1.18.1 to 1.19.0
  • Update SRI integrity hashes for both dependencies

@coderabbitai

coderabbitai Bot commented Aug 17, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 966da59f-25ee-40bc-a8a9-2cb459d56c84


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@yselkowitz yselkowitz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be rebased.

@bhoy-troy
bhoy-troy force-pushed the feature/cdn-deps-update-#131 branch from ad76c9b to 37ae6fd Compare August 18, 2026 14:53
@yselkowitz yselkowitz linked an issue Aug 18, 2026 that may be closed by this pull request
@bhoy-troy
bhoy-troy requested a review from yselkowitz August 18, 2026 22:16

@yselkowitz yselkowitz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

datatables is a major version bump, are there any incompatiblities therein which affect CR?

@bhoy-troy

Copy link
Copy Markdown
Collaborator Author

datatables is a major version bump, are there any incompatiblities therein which affect CR?
#### Some Key changes in DataTables 3:

  • jQuery is no longer a dependency (still works as a plugin if present — which it is in the current state)
  • Callback scope this changed from jQuery instance to DataTable.Dom object
  • columns().search() behavior changed
  • Removed: .cache(), scrollXInner, and JSONP support
  • Sort icons now CSS-generated instead of font-based
  • Internal properties renamed to camelCase

HTML templates are compatible because:

  • CR uses this.api() in initComplete callbacks — this is explicitly preserved in v3
  • jQuery DOM queries (.unbind(), $('.dataTables_filter')) still work since jQuery is loaded
  • Currently use just the single-table api.search() method, not the changed columns().search()
  • None of the removed APIs (.cache(), scrollXInner, etc.) are used
  • Custom CSS already targets icons in sorting cols icons

Comment thread templates/layout.html Outdated
Comment on lines +19 to +20
src="https://cdn.jsdelivr.net/npm/datatables.net@3.0.1/js/dataTables.min.js"
integrity="sha384-stLBvQI26SIgZOke0kAZbmVfcxb89mRjkgJ/aRVpYms4krlKaYvhLnDow4tbqS4U"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ticket was already updated with 3.0.2:

Suggested change
src="https://cdn.jsdelivr.net/npm/datatables.net@3.0.1/js/dataTables.min.js"
integrity="sha384-stLBvQI26SIgZOke0kAZbmVfcxb89mRjkgJ/aRVpYms4krlKaYvhLnDow4tbqS4U"
src="https://cdn.jsdelivr.net/npm/datatables.net@3.0.2/js/dataTables.min.js"
integrity="sha384-c4yknMYbSSMth0KWquBHrA7U+cCWJgg4sdZ3R2KuLzCvc2FB1SFRK7JibRvpgwN1"

@bhoy-troy
bhoy-troy force-pushed the feature/cdn-deps-update-#131 branch from 37ae6fd to 00252ef Compare August 27, 2026 08:40
@bhoy-troy
bhoy-troy requested a review from yselkowitz August 27, 2026 09:14
@bhoy-troy
bhoy-troy merged commit 2e91ea2 into fedora-eln:master Aug 27, 2026
3 checks passed
@bhoy-troy
bhoy-troy deleted the feature/cdn-deps-update-#131 branch August 27, 2026 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🔄 CDN Dependency Updates Available

2 participants